Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imagemagick: remove dev outputs from closure #184922

Merged
merged 2 commits into from
Aug 15, 2022
Merged

imagemagick: remove dev outputs from closure #184922

merged 2 commits into from
Aug 15, 2022

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Aug 2, 2022

Description of changes

Prevent glib.dev reference from ending up in out due to glib being propagated.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jtojnar
liblqr1: split outputs
ff630bd 
Prevent glib.dev reference from ending up in out due to glib being propagated.
@jtojnar
libjxl: split outputs
4eb3247 
Prevent brotli.dev reference from ending up in out due to brotli being propagated.
@jtojnar jtojnar changed the title liblqr1: split outputs imagemagick: remove dev outputs from closure Aug 3, 2022
@ofborg ofborg bot requested a review from nh2 August 3, 2022 00:10
@jtojnar
Copy link
Member Author

jtojnar commented Aug 3, 2022

libjxl’s pkg-config files contain a broken includedir but this is not a regression and will be fixed by #172150.

@jtojnar jtojnar changed the base branch from master to staging August 3, 2022 00:33
@vcunat vcunat merged commit 3e3f52f into NixOS:staging Aug 15, 2022
@jtojnar jtojnar deleted the liblqr1-no-dev branch August 15, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 Awaiting requested review from nh2

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtojnar @vcunat